Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19893 )
Change subject: IMPALA-12145: Fix profiles with non-ascii character in impala-shell (python2) ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19893/2/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/19893/2/shell/shell_output.py@31 PS2, Line 31: def match_string_type(str_to_convert, reference_str): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19893/2/shell/shell_output.py@48 PS2, Line 48: n flake8: F841 local variable 'needs_conversion' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/19893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b72dd262fc7c382e8baee1dce7592880c84de2 Gerrit-Change-Number: 19893 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 11:36:11 +0000 Gerrit-HasComments: Yes
