Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/19893 )
Change subject: IMPALA-12145: Fix profiles with non-ascii character in impala-shell (python2) ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19893/3/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/19893/3/shell/shell_output.py@33 PS3, Line 33: """ Returns 'str_to_convert' converted to the same type as 'reference_str'. It would be good to have specific unit tests for this function especially since the different pytest vectors will exercise the python 2 and 3 paths through this function. -- To view, visit http://gerrit.cloudera.org:8080/19893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b72dd262fc7c382e8baee1dce7592880c84de2 Gerrit-Change-Number: 19893 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 18 May 2023 20:45:29 +0000 Gerrit-HasComments: Yes
