Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20258 )
Change subject: IMPALA-12305: Fix wrong Catalog Service ID when CatalogD becomes active ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20258/2/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20258/2/be/src/catalog/catalog-server.cc@418 PS2, Line 418: if (IsActive()) { : lock_guard<mutex> l(catalog_lock_); > Is there any potential race here? IsActive() obtain catalog_lock_ inside it Good suggestion. changed the code as suggested. Thanks -- To view, visit http://gerrit.cloudera.org:8080/20258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eada89052c5f16209c6f16357f30f78b4497434 Gerrit-Change-Number: 20258 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Jul 2023 20:36:08 +0000 Gerrit-HasComments: Yes
