Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20258 )
Change subject: IMPALA-12305: Fix wrong Catalog Service ID when CatalogD becomes active ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20258/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20258/3/be/src/catalog/catalog-server.cc@410 PS3, Line 410: UpdateRegisteredCatalogd(active_catalogd_registration); : if (FLAGS_force_catalogd_active && !IsActive()) { > I'm still not sure about this line. Can you explain what happen if two Cata If the two catalogd start with FLAGS_force_catalogd_active as true, statestore assign the first one as active, then assign the second one as active. The second one overwrite the first one. There is only one as active. FLAGS_force_catalogd_active should be set by central admin like CM for manual failover, we don't expect both catalogd are started with this flag as true in same time. It's possible to have two concurrent UpdateRegisteredCatalogd calls. We have "sending_sequence_" defined in StatestoreCatalogdMgr to track version of active catalogd. But it's not returned in the registration response. I can address this issue in following patch. FLAGS_force_catalogd_active is not used in R36. UpdateRegisteredCatalogd() is also called from notification callback. I don't like to return is_final. But we can pass a variable pointer for is_active. If the pointer is not null, return the current active status. -- To view, visit http://gerrit.cloudera.org:8080/20258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eada89052c5f16209c6f16357f30f78b4497434 Gerrit-Change-Number: 20258 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Jul 2023 22:06:41 +0000 Gerrit-HasComments: Yes
