Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20258 )
Change subject: IMPALA-12305: Fix wrong Catalog Service ID when CatalogD becomes active ...................................................................... Patch Set 3: (1 comment) I'm sorry, I have one more question. http://gerrit.cloudera.org:8080/#/c/20258/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20258/3/be/src/catalog/catalog-server.cc@410 PS3, Line 410: UpdateRegisteredCatalogd(active_catalogd_registration); : if (FLAGS_force_catalogd_active && !IsActive()) { I'm still not sure about this line. Can you explain what happen if two Catalogd start with FLAGS_force_catalogd_active == true? Is it possible for both to fail or both start as active? What is different between UpdateRegisteredCatalogd as direct call in line 410 and ass statestore_subscriber_ callback in line 402? Is it possible to have two concurrent UpdateRegisteredCatalogd around this callsite? Is it cleaner to change UpdateRegisteredCatalogd to return is_final_ instead of void? That way, this can be written as: if (!UpdateRegisteredCatalogd(active_catalogd_registration) && FLAGS_force_catalogd_active) { And then IsActive() can be removed. -- To view, visit http://gerrit.cloudera.org:8080/20258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eada89052c5f16209c6f16357f30f78b4497434 Gerrit-Change-Number: 20258 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Jul 2023 21:25:17 +0000 Gerrit-HasComments: Yes
