Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 )
Change subject: [tools] Simplify local toolchain development ...................................................................... Patch Set 3: One minor thing: Some developers use a single $IMPALA_TOOLCHAIN location for multiple Impala checkouts. If we add toolchain-local in that shared directory, then other checkouts could be impacted (if they have this code). This is easy to workaround (set IMPALA_TOOLCHAIN to not use the shared location), so it isn't a big deal. I like the idea of a mode that points to a toolchain and builds it. I think it would be useful for non-aarch64 circumstances as well. Being able to set an env var that says "build the toolchain from scratch" and corresponding vars to customize a native-toolchain checkout location / toolchain storage location would be nice. -- To view, visit http://gerrit.cloudera.org:8080/20267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e51b7f54c738d8cc01b32428ac88a344de376 Gerrit-Change-Number: 20267 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Aug 2023 16:00:00 +0000 Gerrit-HasComments: No
