Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 )
Change subject: [tools] Simplify local toolchain development ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20267/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20267/3/bin/impala-config.sh@319 PS3, Line 319: fi > I was thinking it might be nice to combine this with some of the logic for Done. I also rolled in https://gerrit.cloudera.org/c/19885/ as part of setting up NATIVE_TOOLCHAIN_HOME with the correct ref. -- To view, visit http://gerrit.cloudera.org:8080/20267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e51b7f54c738d8cc01b32428ac88a344de376 Gerrit-Change-Number: 20267 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Aug 2023 21:12:54 +0000 Gerrit-HasComments: Yes
