Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 )
Change subject: IMPALA-10086: Implicit cast comparing char and varchar ...................................................................... Patch Set 1: (3 comments) > Patch Set 1: > > > Patch Set 1: > > > > I'll run a perf-AB-test, as this may have performance implications. > > https://jenkins.impala.io/job/perf-AB-test/473/ Unfortunately, we don't use char/varchar in our tpch/tpcds data sets: https://github.com/apache/impala/blob/master/testdata/datasets/tpch/tpch_schema_template.sql https://github.com/apache/impala/blob/master/testdata/datasets/tpcds/tpcds_schema_template.sql So the current perf-AB-test can't reveal any difference. Optional: we can add a targeted-perf test in testdata/workloads/targeted-perf/queries. http://gerrit.cloudera.org:8080/#/c/20425/1/fe/src/test/java/org/apache/impala/analysis/TypesUtilTest.java File fe/src/test/java/org/apache/impala/analysis/TypesUtilTest.java: http://gerrit.cloudera.org:8080/#/c/20425/1/fe/src/test/java/org/apache/impala/analysis/TypesUtilTest.java@255 PS1, Line 255: } What about adding some unit tests in TypesUtilTest.java? http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py@2189 PS1, Line 2189: self nit: add 'unique_database' and create the table under it. The 'unique_database' fixture will handle the cleanup so we don't need to drop the table at the beginning. https://github.com/apache/impala/blob/0c8fc997ef7df09b675180a7baa1482852d60b11/tests/conftest.py#L376 http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py@2197 PS1, Line 2197: assert ['test \ttest', 'tester\ttester'] == self.execute_query( > This test suite matches the behavior we used to have with Impala 3.2 (as se Do you know which JIRA introduces the regression? -- To view, visit http://gerrit.cloudera.org:8080/20425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 29 Aug 2023 07:03:51 +0000 Gerrit-HasComments: Yes
