Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#2). Change subject: IMPALA-10086: Implicit cast comparing char and varchar ...................................................................... IMPALA-10086: Implicit cast comparing char and varchar Allow implicit cast between matching types. That includes equals, and adds casting to a compatible type when it is a char or varchar and the target type is a wildcard version of the same. Adds tests covering cast comparison and other implicit conversions. Does not attempt to address differences from CHAR padding (IMPALA-1652). Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M tests/query_test/test_cast_with_format.py 3 files changed, 71 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20425/2 -- To view, visit http://gerrit.cloudera.org:8080/20425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>