Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 )
Change subject: IMPALA-10086: Implicit cast comparing char and varchar ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20425/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20425/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-10086 > What's the relationship of this change to https://gerrit.cloudera.org/#/c/1 It was attempting to provide a more complete fix. The SqlCastException was filed as a bug because in prior Impala (circa 3.2) it used to cast correctly. The fix in 18001 removed the exception, but didn't actually work. http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py File tests/query_test/test_cast_with_format.py: http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py@2189 PS1, Line 2189: self > nit: add 'unique_database' and create the table under it. Ack http://gerrit.cloudera.org:8080/#/c/20425/1/tests/query_test/test_cast_with_format.py@2197 PS1, Line 2197: assert ['test \ttest', 'tester\ttester'] == self.execute_query( > Do you know which JIRA introduces the regression? I didn't identify the specific JIRA or commit. Given that this change is insufficient, that may be my next step. -- To view, visit http://gerrit.cloudera.org:8080/20425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89d0a391bc8f2152ecd9151c8872a01ba19c436 Gerrit-Change-Number: 20425 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 01:48:42 +0000 Gerrit-HasComments: Yes
