Hello Riza Suminto, David Rorke, Surya Hebbar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20377
to look at the new patch set (#5).
Change subject: IMPALA-12385: Enable Periodic metrics by default
......................................................................
IMPALA-12385: Enable Periodic metrics by default
This patch enables periodic metrics in query profiles by default and
changes the metric collectors to be more suitable for mixed workloads.
-Change default of resource_trace_ratio to 1
-Use samplng counters which can automatically resize for long queries
-Reduce metric interval to 50ms to support short-running queries
-Added new flag periodic_system_counter_update_period_ms and additional
update thread to preserve 500ms update interval for KRPC metrics
-Fragment metrics use the same sample interval as periodic metrics
Testing:
-Updated runtime-profile-test and test_observability.py for new defaults
-Manual inspection of query profile metrics for long-running queries
-Tested for performance regression using 50 concurrent TPCH Q1 and with
periodic_counter_update_period_ms=1 to verify that the periodic update
loop does not affect peformance or become a bottleneck
Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1
---
M be/src/runtime/exec-env.cc
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/query-state.cc
M be/src/util/periodic-counter-updater.cc
M be/src/util/periodic-counter-updater.h
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
M be/src/util/streaming-sampler.h
M common/thrift/Query.thrift
M tests/query_test/test_observability.py
12 files changed, 139 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/20377/5
--
To view, visit http://gerrit.cloudera.org:8080/20377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1
Gerrit-Change-Number: 20377
Gerrit-PatchSet: 5
Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: David Rorke <dro...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com>
