Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 )
Change subject: IMPALA-12385: Enable Periodic metrics by default ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/20377/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20377/5//COMMIT_MSG@15 PS5, Line 15: -Added new flag periodic_system_counter_update_period_ms and additional : update thread to preserve 500ms update interval for KRPC metrics Mention the new separate system_instance_ singleton in commit message. http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/periodic-counter-updater.h File be/src/util/periodic-counter-updater.h: http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/periodic-counter-updater.h@158 PS5, Line 158: /// Singleton object that keeps track of all profile rate counters and the thread : /// for updating them. nit: mention the flag or the default sampling period for this singleton. http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/periodic-counter-updater.h@162 PS5, Line 162: /// Singleton object that keeps track of all system rate counters and the thread : /// for updating them. nit: mention the flag or the default sampling period for this singleton. http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/periodic-counter-updater.cc File be/src/util/periodic-counter-updater.cc: http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/periodic-counter-updater.cc@47 PS5, Line 47: the singleton nit: two singleton http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/20377/5/be/src/util/runtime-profile.h@156 PS5, Line 156: bool is_system_; Looks like is_system_ is always false for RuntimeProfile::Counter. Is it OK to remove this and assume all RuntimeProfile::Counter is non-system in periodic-counter-updater.cc? -- To view, visit http://gerrit.cloudera.org:8080/20377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1 Gerrit-Change-Number: 20377 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Aug 2023 17:52:12 +0000 Gerrit-HasComments: Yes
