Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 )
Change subject: IMPALA-12385: Enable Periodic metrics by default ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@12 PS1, Line 12: resource_trace_ratio to > Done https://issues.apache.org/jira/browse/IMPALA-7694 seems to posit that it might be a problem, but doesn't provide any support that it is. They seem to have just assumed it would be and made it disabled by default. http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@13 PS1, Line 13: -Changed profile metrics to use samplng counters which can automatically nit: type in samplng http://gerrit.cloudera.org:8080/#/c/20377/1//COMMIT_MSG@14 PS1, Line 14: resize for long queries. Can you add an example of how this shows up in a Profile? http://gerrit.cloudera.org:8080/#/c/20377/6/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/20377/6/be/src/util/runtime-profile-counters.h@822 PS6, Line 822: , samples_(initial_period) {} nit: this formatting doesn't seem consistent with our usual style. http://gerrit.cloudera.org:8080/#/c/20377/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/20377/6/tests/query_test/test_observability.py@549 PS6, Line 549: # We check for 500ms because a query with 1s duration won't hit the 64 values limit Comment should say 50ms now. -- To view, visit http://gerrit.cloudera.org:8080/20377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1 Gerrit-Change-Number: 20377 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Sep 2023 21:18:40 +0000 Gerrit-HasComments: Yes
