Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/2/bin/gen_build_version.py File bin/gen_build_version.py: Line 35: can_obtain_git_hash = call(['git', 'rev-parse', 'HEAD'], stdout=PIPE, stderr=PIPE) == 0 Python docs discourage using PIPE here as it can block, depending on the output volume of the subprocess (https://docs.python.org/2/library/subprocess.html). However, in your case you're not reading the output, so you could just use None for both instead, which is also the default. Line 43: # SAVE_VERSION_SCRIPT will generate a dummy version.info file if we cannot obtain the Maybe replace L54 with this? http://gerrit.cloudera.org:8080/#/c/4411/2/bin/save-version.sh File bin/save-version.sh: Line 25: GIT_HASH=$(git rev-parse HEAD) > /dev/null I think this should be 2> /dev/null, no? -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
