Sailesh Mukil has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_version.py File bin/gen_build_version.py: Line 35: # Redirecting stdout and stderr to os.devnull > nit: You could remove both parameters altogether, since None is the default Didn't realize this earlier, but None actually doesn't redirect stdout or stderr. So it does end up getting printed on stdout/stderr. I've added a change to redirect to os.devnull. -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
