Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_version.py File bin/gen_build_version.py: Line 35: can_obtain_git_hash = call(['git', 'rev-parse', 'HEAD'], stdout=None, stderr=None) == 0 nit: You could remove both parameters altogether, since None is the default for both. -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
