Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 1: (6 comments) Thank you for working on this. Please make sure your change follows the general style guidelines of impala, especially with regards to whitespace. http://gerrit.cloudera.org:8080/#/c/4971/1//COMMIT_MSG Commit Message: Please re-format the commit message to wrap lines at 80 characters PS1, Line 2: davidxdh nit: you might want to configure git to include your name here PS1, Line 10: spill fill up http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/init.cc File be/src/common/init.cc: PS1, Line 68: 100 I don't think we should set a default here, because audit information might be sensitive to retention policies we don't control. I'll asked this as a question in the Jira. Line 69: "level. The most recent audit event log files are retained. If set to 0, all audit event log files are " Use spaces instead of tabs, wrap lines at 90 characters. You can use git-clang-format to format whitespace. This page contains more information: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/logging.cc File be/src/common/logging.cc: Line 58: const string AUDIT_EVENT_LOG_FILE_PREFIX = "impala_audit_event_log_1.0-"; Where in the code do we make sure that event log files are always written with this name prefix? Can you take that information and re-use it here? -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: davy...@163.com Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
