Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 6: (4 comments) There are still some minor formatting issues left. Have you actually run git-clang-format on your change? That should fix them automatically. Also, have you thought about how we can test this new behaviour, both to make sure it works as intended and does not break other features? http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/init.cc File be/src/common/init.cc: Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > Please follow the indentation of the surrounding code This still needs to be done. http://gerrit.cloudera.org:8080/#/c/4971/6/be/src/common/logging.cc File be/src/common/logging.cc: Line 186: ImpalaServer::GetAuditEventLogFilePrefix()); much better :) http://gerrit.cloudera.org:8080/#/c/4971/6/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 271: /// Get the prefix of audit event log filename nit: dot. Line 272: static std::string GetAuditEventLogFilePrefix(); Please remove trailing whitespace. Also check other files. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
