Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 4: (2 comments) Please address the questions in my previous comments and mark them as "Done" once they are addressed. http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/logging.cc File be/src/common/logging.cc: Line 58: // Prefix of audit event log filename. The version number is > Please address this comment. This variable is defined in impala-server.cc:195, too. Can you reuse that definition here instead of duplicating it? http://gerrit.cloudera.org:8080/#/c/4971/4/be/src/common/logging.h File be/src/common/logging.h: PS4, Line 85: /// Helper function that checks for the number of logfiles in the log directory and removes please wrap this paragraph and the one below at 90 characters. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
