Alex Behm has posted comments on this change. Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5164/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 396: if IS_HDFS: Instead of this if/else logic, how about we split out only those hdfs-specific tests? Seems like we'll need fewer lines .test files. Code like this: self.run_test_case(file_for_all_fs) if IS_HDFS: self.run_test_case(hdfs_specific_tests) -- To view, visit http://gerrit.cloudera.org:8080/5164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8606aa427cb6e50be3395cdde246abb53db5172c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-HasComments: Yes
