Alex Behm has posted comments on this change. Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5164/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 396: if IS_HDFS: > We can do that, but I see a problem with that. This test currently creates, Good points. I'm more worried about having to copy+paste tests in two different places in the future. I agree about the test dependencies, we definitely do not want that. I'd still prefer option 1, even if the tests take a little longer (is it really double? seems awfully high). You might be able to reduce the number of partitions used in the hdfs-specific tests. There's no need to replicate the tests verbatim as long as the hdfs-specific tests logically still cover the same thing. -- To view, visit http://gerrit.cloudera.org:8080/5164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8606aa427cb6e50be3395cdde246abb53db5172c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
