Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5164/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 396: self.run_test_case('QueryTest/partition-ddl-predicates-all-fs', vector, > Good points. I'm more worried about having to copy+paste tests in two diffe Makes sense. I went with option 1 and made the hdfs-specific file not have a lot of repeat queries. It takes ~33 seconds to run overall now on HDFS, so not too bad. -- To view, visit http://gerrit.cloudera.org:8080/5164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8606aa427cb6e50be3395cdde246abb53db5172c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes