Alex Behm has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally. ......................................................................
Patch Set 2: (4 comments) Is the motivation of this change to get Jenkins jobs run against a remote cluster green? Please briefly summarize the motivation of this change. http://gerrit.cloudera.org:8080/#/c/5446/2/tests/common/skip.py File tests/common/skip.py: Line 122: mini_cluster_only = pytest.mark.skipif(pytest.config.option.testing_remote_cluster, Why skip and not xfail? With xfail we have the option of still running the tests, e.g., to detect crashes. http://gerrit.cloudera.org:8080/#/c/5446/2/tests/conftest.py File tests/conftest.py: Line 108: parser.addoption("--testing_remote_cluster", action="store_true", default=False, I'm ok with adding this flag, but I think we should enforce its semantics. Currently, we can set this flag regardless of whether we are testing on a remote cluster or not which seems potentially error-prone. Line 109: help="Indicates that tests are being run against a remote cluster.") Mention what effect this flag has. It will cause tests to be skipped. http://gerrit.cloudera.org:8080/#/c/5446/2/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 95: @SkipIfRemoteTesting.mini_cluster_only Does test_nested_types.py or test_tpch_nested_queries.py succeed on a remote cluster? I'm surprised that only this test would be skipped of loading tpch_nested is not working. -- To view, visit http://gerrit.cloudera.org:8080/5446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
