David Knupp has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5446/2/tests/common/skip.py File tests/common/skip.py: Line 122 > Why skip and not xfail? With xfail we have the option of still running the I think switching to xfail is a great suggestion. As such, I'll remove the SkipIf class for now. http://gerrit.cloudera.org:8080/#/c/5446/2/tests/conftest.py File tests/conftest.py: Line 108: parser.addoption("--testing_remote_cluster", action="store_true", default=False, > I'm ok with adding this flag, but I think we should enforce its semantics. I'm adding an autouse fixture to conftest.py to make sure that we don't allow --testing_remote_cluster when impalad ~ localhost. Let me know if you had something more sophisticated in mind. Line 109: help=("Indicates that tests are being run against a remote cluster. " > Mention what effect this flag has. It will cause tests to be skipped. Done http://gerrit.cloudera.org:8080/#/c/5446/2/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 95: @pytest.mark.xfail(pytest.config.option.testing_remote_cluster, > Does test_nested_types.py or test_tpch_nested_queries.py succeed on a remot Those tests don't pass yet either. We actually ruled those module out entirely until we can get to the root of the problem. However, there were only a couple of failing tests in this module, and it seemed like a good reason to introduce a temporary workaround so that we can still run the others. -- To view, visit http://gerrit.cloudera.org:8080/5446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
