Alex Behm has posted comments on this change.

Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that 
only run locally.
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5446/3/tests/conftest.py
File tests/conftest.py:

Line 480:   Validate that pytest command line options makes sense.
typo: make sense


Line 483:     if "localhost" in pytest.config.option.impalad:
or "127.0.0.1" ?


http://gerrit.cloudera.org:8080/#/c/5446/3/tests/metadata/test_compute_stats.py
File tests/metadata/test_compute_stats.py:

Line 135:                      reason=("Because of the way we pre-split the 
data, setting up HBase "
add JIRA to the reason, so we can easily fix all the places later if needed


-- 
To view, visit http://gerrit.cloudera.org:8080/5446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to