anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7332/4//COMMIT_MSG Commit Message: PS4, Line 9: Privileges granted to a role assigned > Privileges are granted "to" roles "on" objects. I think this might need a l Done http://gerrit.cloudera.org:8080/#/c/7332/4/fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java File fe/src/main/java/org/apache/impala/catalog/RolePrivilege.java: PS4, Line 76: // (IMPALA-2695) URIs are case sensitive : authorizable.add(KV_JOINER.join("uri", privilege.getUri() > // (IMPALA-2695) URIs are case sensitive. Done http://gerrit.cloudera.org:8080/#/c/7332/4/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: PS4, Line 106: dom_id(5) > Could you randomize it as discussed in the other thread? Look for usages of Done. I thought we should fix this after fixing IMPALA-5660 PS4, Line 127: self.cli > you tested that this fails without your change? I'm just wondering if 2sec yes, It failed without this change if statestore_update_frequency_ms is set to a high value. I had removed it in the last patch. Setting it back to 300ms. I did try running this test on asf master but with a sleep > 1 min since sentry_catalog_polling_frequency_s was not part of it. PS4, Line 135: grant all on d > drop database if exists Done -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
