Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8029/1/be/src/exec/filter-context.h File be/src/exec/filter-context.h: Line 124: static Status CodegenInsert(LlvmCodeGen* codegen, ScalarExpr* filter_expr, > This is a bit tricky because it doesn't actually do exactly the same thing Done http://gerrit.cloudera.org:8080/#/c/8029/1/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: Line 953: for (int i = 0; i < num_filters; ++i) { > Nit: it looks like the two branches are identical except for adding the NoI Done Line 958: Value* filter_context_ptr = > Going forward, we want to avoid have this dependence between the codegen co Done http://gerrit.cloudera.org:8080/#/c/8029/1/be/src/util/bloom-filter-ir.cc File be/src/util/bloom-filter-ir.cc: Line 32: } > It would be nice to keep this in header file to avoid regressing the non-co Done -- To view, visit http://gerrit.cloudera.org:8080/8029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79cf23ad92dadaab996a50a2ca07ef9ebe8639bb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
