Tim Armstrong has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exec/CMakeLists.txt File be/src/exec/CMakeLists.txt: Line 40: filter-context-ir.cc Missing this file? http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exec/filter-context.cc File be/src/exec/filter-context.cc: Line 225: Constant* expr_type_arg = codegen->ConstantToGVPtr( This does look like it should work to me. I think the types should line up - i.e. ColumnType* and ColumnType*. http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: Line 368: // Set the pointer to NULL in case it evaluates to NULL. It seems like the main way this differs from other places is returning a null pointer if IsNull() is true. Could we just wrap that up in something like a CodegenAnyVal.ToNullableNativePtr() method and avoid the boilerplate of creating a whole new function? -- To view, visit http://gerrit.cloudera.org:8080/8029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79cf23ad92dadaab996a50a2ca07ef9ebe8639bb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
