Tim Armstrong has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters ......................................................................
Patch Set 2: Code-Review+1 (4 comments) Looks good to me minus a couple of things. Not sure if Dan wants to take a look http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc File be/src/exec/filter-context.cc: Line 216: Forgot in the previous pass: can you include an example of the IR it generates? Line 217: Status FilterContext::CodegenInsert( It would be nice not to add the IRBuilder code but we don't have a good path yet to automatically unroll loops in cross-compiled code. This seems pretty reasonable as far as IRBuilder code - I didn't see any obvious opportunities to simplify things. http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: Line 935: Status PhjBuilder::CodegenInsertRuntimeFilters( It would be good to have an example of the IR here too. http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/util/bloom-filter-ir.cc File be/src/util/bloom-filter-ir.cc: PS2, Line 24: IR_ALWAYS_INLINE Is the always_inline needed here? -- To view, visit http://gerrit.cloudera.org:8080/8029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79cf23ad92dadaab996a50a2ca07ef9ebe8639bb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
