Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 )
Change subject: IMPALA-6060: Check the return value of JNI exception handling functions ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8334/1/be/src/util/jni-util.cc File be/src/util/jni-util.cc: http://gerrit.cloudera.org:8080/#/c/8334/1/be/src/util/jni-util.cc@193 PS1, Line 193: env->ExceptionClear(); > This case of auto obscures the code. Might not be clear to everybody that t Done http://gerrit.cloudera.org:8080/#/c/8334/1/be/src/util/jni-util.cc@197 PS1, Line 197: } > You are right that RETURN_ERROR_IF_EXC() does not make sense here. Done -- To view, visit http://gerrit.cloudera.org:8080/8334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ed88bf8739c56a066f2402727c8204e96aa116 Gerrit-Change-Number: 8334 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 20:56:22 +0000 Gerrit-HasComments: Yes
