Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8334 )

Change subject: IMPALA-6060: Check the return value of JNI exception handling 
functions
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc
File be/src/util/jni-util.cc:

http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc@190
PS3, Line 190:   jstring msg = 
static_cast<jstring>(env->CallStaticObjectMethod(jni_util_class(),
> It is somewhat obvious from the static_cast, of course. Still, auto general
Done


http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc@194
PS3, Line 194:     string oom_msg = Substitute(oom_msg_template, 
"throwableToString");
> no auto please
Done


http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc@201
PS3, Line 201:     jstring stack = 
static_cast<jstring>(env->CallStaticObjectMethod(jni_util_class(),
> no auto please
Done


http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc@205
PS3, Line 205:       string oom_msg = Substitute(oom_msg_template, 
"throwableToStackTrace");
> no auto please
Done



--
To view, visit http://gerrit.cloudera.org:8080/8334
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3ed88bf8739c56a066f2402727c8204e96aa116
Gerrit-Change-Number: 8334
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 17:14:20 +0000
Gerrit-HasComments: Yes

Reply via email to