Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8334 )
Change subject: IMPALA-6060: Check the return value of JNI exception handling functions ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc File be/src/util/jni-util.cc: http://gerrit.cloudera.org:8080/#/c/8334/3/be/src/util/jni-util.cc@190 PS3, Line 190: auto msg = static_cast<jstring>(env->CallStaticObjectMethod(jni_util_class(), > Same here and in other cases below: The use of auto obscures the code. This It is somewhat obvious from the static_cast, of course. Still, auto generally adds cognitive burden to the reader unless it really helps readability -- To view, visit http://gerrit.cloudera.org:8080/8334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ed88bf8739c56a066f2402727c8204e96aa116 Gerrit-Change-Number: 8334 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Oct 2017 00:42:57 +0000 Gerrit-HasComments: Yes
