Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 )
Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@959 PS1, Line 959: if (tmp_buffer.TryAllocate(uncompressed_size)) { It turned out that this can violate a dcheck, if uncompressed_size is 0, which seems valid if every value of a column in a partition is NULL. This is the case in a partition of functional_parquet.alltypesagg/tinyint_col, which lead to a crash in one of the tests. I think that there should be a table/column with all NULL values by design to test this case explicitly. -- To view, visit http://gerrit.cloudera.org:8080/8436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 Gerrit-Change-Number: 8436 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Nov 2017 00:44:57 +0000 Gerrit-HasComments: Yes
