Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 )
Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction ...................................................................... Patch Set 4: (4 comments) Looks close. http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@934 PS4, Line 934: NULL nullptr http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@942 PS4, Line 942: // 3. If the column type is not string, and the dictionary page is not compressed, I'm not 100% confident that we have test coverage for this case - we have somewhat limited testing of uncompressed parquet (the parquet/none tests are actually snappy-compressed since that's the default). I think the main coverage we have is tests that insert into parquet and read it back. I took a look and it seems like tests/query_test/test_insert_parquet.py should exercise this code path, but could you confirm? E.g. add a log message on each branch and make sure that they appear in the logs. http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@944 PS4, Line 944: nit: unnecessary blank line http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@964 PS4, Line 964: ) nit: != nullptr (we prefer explicit checks against null to make it visually obvious that it's a null check). -- To view, visit http://gerrit.cloudera.org:8080/8436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 Gerrit-Change-Number: 8436 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Nov 2017 00:39:36 +0000 Gerrit-HasComments: Yes
