Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 )
Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.h@376 PS1, Line 376: virtual bool DictionaryReferencesBuffer() const { return false; } > Add comment. Make pure if possible. Alternatively, you could do something s I have removed this and the other similar functions, and used directly slot_desc_->type().IsVarLenStringType() instead. http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@272 PS1, Line 272: virtual bool DictionaryReferencesBuffer() const { > add "override" This function was removed. http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@541 PS1, Line 541: some > how about rewording this to "Column readers for types that require ..." This function was removed. http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@542 PS1, Line 542: inline bool DictionaryReferencesBufferInline() const { > nit: single line This function was removed. http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@945 PS1, Line 945: tmp_buffer > better name Done http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@947 PS1, Line 947: int uncompressed_size = decompressor_.get() != nullptr > Move this to L954 Done http://gerrit.cloudera.org:8080/#/c/8436/1/be/src/exec/parquet-column-readers.cc@951 PS1, Line 951: if (decompressor_.get() == nullptr && !DictionaryReferencesBuffer()) { > Can you add a brief comment to explain how the 4 different cases are handle Done -- To view, visit http://gerrit.cloudera.org:8080/8436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 Gerrit-Change-Number: 8436 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Nov 2017 22:39:36 +0000 Gerrit-HasComments: Yes