HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776311802
########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ########## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.confignode.procedure.env; + +import org.apache.iotdb.common.rpc.thrift.TConsensusGroupId; +import org.apache.iotdb.common.rpc.thrift.TConsensusGroupType; +import org.apache.iotdb.common.rpc.thrift.TDataNodeConfiguration; +import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation; +import org.apache.iotdb.common.rpc.thrift.TEndPoint; +import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet; +import org.apache.iotdb.common.rpc.thrift.TSStatus; +import org.apache.iotdb.commons.client.ClientPoolFactory; +import org.apache.iotdb.commons.client.IClientManager; +import org.apache.iotdb.commons.client.sync.SyncDataNodeInternalServiceClient; +import org.apache.iotdb.commons.cluster.NodeStatus; +import org.apache.iotdb.commons.cluster.NodeType; +import org.apache.iotdb.commons.cluster.RegionStatus; +import org.apache.iotdb.commons.service.metric.MetricService; +import org.apache.iotdb.commons.utils.NodeUrlUtils; +import org.apache.iotdb.confignode.client.CnToDnRequestType; +import org.apache.iotdb.confignode.client.sync.SyncDataNodeClientPool; +import org.apache.iotdb.confignode.conf.ConfigNodeConfig; +import org.apache.iotdb.confignode.conf.ConfigNodeDescriptor; +import org.apache.iotdb.confignode.consensus.request.write.datanode.RemoveDataNodePlan; +import org.apache.iotdb.confignode.consensus.response.datanode.DataNodeToStatusResp; +import org.apache.iotdb.confignode.manager.ConfigManager; +import org.apache.iotdb.confignode.manager.load.cache.node.NodeHeartbeatSample; +import org.apache.iotdb.confignode.manager.load.cache.region.RegionHeartbeatSample; +import org.apache.iotdb.confignode.manager.partition.PartitionMetrics; +import org.apache.iotdb.confignode.persistence.node.NodeInfo; +import org.apache.iotdb.confignode.procedure.impl.region.RegionMigrationPlan; +import org.apache.iotdb.consensus.exception.ConsensusException; +import org.apache.iotdb.mpp.rpc.thrift.TCleanDataNodeCacheReq; +import org.apache.iotdb.rpc.TSStatusCode; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.TreeMap; +import java.util.stream.Collectors; + +import static org.apache.iotdb.confignode.conf.ConfigNodeConstant.REMOVE_DATANODE_PROCESS; +import static org.apache.iotdb.consensus.ConsensusFactory.SIMPLE_CONSENSUS; +import static org.apache.iotdb.db.service.RegionMigrateService.isFailed; +import static org.apache.iotdb.db.service.RegionMigrateService.isSucceed; + +public class RemoveDataNodeManager { + + private static final Logger LOGGER = LoggerFactory.getLogger(RemoveDataNodeManager.class); + + private static final ConfigNodeConfig CONF = ConfigNodeDescriptor.getInstance().getConf(); + + private final ConfigManager configManager; + + private final IClientManager<TEndPoint, SyncDataNodeInternalServiceClient> dataNodeClientManager; + + public RemoveDataNodeManager(ConfigManager configManager) { + this.configManager = configManager; + dataNodeClientManager = + new IClientManager.Factory<TEndPoint, SyncDataNodeInternalServiceClient>() + .createClientManager( + new ClientPoolFactory.SyncDataNodeInternalServiceClientPoolFactory()); + } + + /** + * Check if the data nodes are sufficient after removing. + * + * @param removedDataNodes List<TDataNodeLocation> + * @return true if the number of DataNodes is enough, false otherwise + */ + public boolean checkEnoughDataNodeAfterRemoving(List<TDataNodeLocation> removedDataNodes) { + final int availableDatanodeSize = + configManager + .getNodeManager() + .filterDataNodeThroughStatus(NodeStatus.Running, NodeStatus.ReadOnly) + .size(); + + int dataNodeNumAfterRemoving = availableDatanodeSize; + for (TDataNodeLocation removedDatanode : removedDataNodes) { + if (configManager.getLoadManager().getNodeStatus(removedDatanode.getDataNodeId()) + != NodeStatus.Unknown) { + dataNodeNumAfterRemoving = availableDatanodeSize - 1; + } + } Review Comment: resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
