HxpSerein commented on code in PR #13559:
URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778213794
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java:
##########
@@ -123,8 +132,10 @@ protected Flow executeFromState(ConfigNodeProcedureEnv
env, RemoveDataNodeState
}
private void submitChildRegionMigrate(ConfigNodeProcedureEnv env) {
- migratedDataNodeRegions.forEach(
- regionId -> {
+ regionMigrationPlans.forEach(
+ regionMigrationPlan -> {
+ TConsensusGroupId regionId = regionMigrationPlan.getRegionId();
+ TDataNodeLocation removedDataNode =
regionMigrationPlan.getFromDataNode();
TDataNodeLocation destDataNode =
Review Comment:
Good suggestion! This is a very important optimization, but considering the
time limit, I recommend detailed design and optimization in V2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
