HxpSerein commented on code in PR #13559:
URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778230749
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java:
##########
@@ -144,19 +145,26 @@ protected void start() throws IoTDBException {
}
@Override
- protected void remove(Long nodeId) throws IoTDBException {
+ protected void remove(Set<Integer> nodeIds) throws IoTDBException {
// If the nodeId was null, this is a shorthand for removing the current
dataNode.
// In this case we need to find our nodeId.
- if (nodeId == null) {
- nodeId = (long) CONF.getConfigNodeId();
+
+ int removeConfigNodeId = -1;
+ if (nodeIds == null) {
+ removeConfigNodeId = CONF.getConfigNodeId();
+ } else {
+ if (nodeIds.size() != 1) {
+ throw new IoTDBException("Invalid node-id", -1);
Review Comment:
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
