Adar Dembo has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4059/1//COMMIT_MSG Commit Message: PS1, Line 10: there is a CHECK that was missed : in the initial patch Do you mean there's a CHECK that must be softened? If so, I don't see that change in this patch. http://gerrit.cloudera.org:8080/#/c/4059/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3177: // Defaults to true in old versions of Kudu. I thought this comment implied that we need only set obsolete_local if it's going to be false, because if it's true, well, that's the default value in old versions anyway. So why do we need to set it in both cases now? What changed in our understanding of how protobuf handles missing optional booleans? Can you update the comment so it's more useful? -- To view, visit http://gerrit.cloudera.org:8080/4059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icded76c6400b4802581671e2e41efb74a47c5ec4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
