Todd Lipcon has posted comments on this change. Change subject: Actually support downgrade to version that has LocalConsensus ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4059/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3177: // Defaults to true in old versions of Kudu. > I thought this comment implied that we need only set obsolete_local if it's I guess the issue is this code in 0.9.1: todd@todd-ThinkPad-T540p:~/git/kudu$ git grep -A5 'has_local' 0.9.1 0.9.1:src/kudu/consensus/quorum_util.cc: if (!config.has_local()) { 0.9.1:src/kudu/consensus/quorum_util.cc- return Status::IllegalState( 0.9.1:src/kudu/consensus/quorum_util.cc- Substitute("RaftConfig must specify whether it is local. RaftConfig: ", 0.9.1:src/kudu/consensus/quorum_util.cc- config.ShortDebugString())); 0.9.1:src/kudu/consensus/quorum_util.cc- } 0.9.1:src/kudu/consensus/quorum_util.cc- In other words, if we don't set the 'local' flag, it would default to 'true', but has_local() would still return false. -- To view, visit http://gerrit.cloudera.org:8080/4059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icded76c6400b4802581671e2e41efb74a47c5ec4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
