Adar Dembo has posted comments on this change.

Change subject: Actually support downgrade to version that has LocalConsensus
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

Feel free to punt.

http://gerrit.cloudera.org:8080/#/c/4059/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

PS4, Line 3178:   if (nreplicas == 1) {
              :     config->set_obsolete_local(true);
              :   } else {
              :     config->set_obsolete_local(false);
              :   }
Nit: maybe "config->set_obsolete_local(nreplicas == 1)"?


-- 
To view, visit http://gerrit.cloudera.org:8080/4059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icded76c6400b4802581671e2e41efb74a47c5ec4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to