Jordan Birdsell has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4417/4/python/kudu/util.py File python/kudu/util.py: Line 43: the number of microseconds since the unix epoch > should clarify the timezone handling. If I wrote "14:34:05" does that mean UTC, but good point, added some some checks/conversions as well in case the incoming datetime has a timezone assigned. Line 64: raise ValueError("Invalid timestamp type. " + > what's the range of Python datetime? Is this always possible? Also, are you Made sure its tz aware, but strictly only returns UTC. As for range, its 1/1/1 0:0:0.000000 to 12/31/9999 23:59:59.999999. While this doesnt anywhere near cover the full range of int64_t, it does have a pretty wide range. Do you think we need to account for values outside of that range? -- To view, visit http://gerrit.cloudera.org:8080/4417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
