Todd Lipcon has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx File python/kudu/client.pyx: Line 1772: # eg: ("2016-01-01", "%Y-%m-%d") where are these capabilities documented? maybe PartialRow should have a pydoc with some example usage, and documentation regarding timestamps in particular since it's non-obvious? Line 1779: to_unixtime_micros(value)) while we're here, maybe we should add a blanket else: raise Exception("Unable to set kudu type <foo>") type thing so we don't have silent errors in the future? also, this line should be indented a bit http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/util.py File python/kudu/util.py: Line 26: timezone provided. nit: trailing space Line 68: if timestamp.tzinfo: https://docs.python.org/2/library/datetime.html#datetime.datetime.now says that a timestamp is considered "naive" unless it has both a tzinfo and utcoffset() returns something other than None. So, I guess this should also check that utcoffset() is not None? -- To view, visit http://gerrit.cloudera.org:8080/4417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
