Jordan Birdsell has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx File python/kudu/client.pyx: Line 1772: elif t == KUDU_DOUBLE: > where are these capabilities documented? maybe PartialRow should have a pyd Agreed, so, the pydoc stuff is going to take some rework of the docstrings and some structure of the package after looking through it. Are you thinking we should address it class by class or do the api docs for the whole package at once. If we want to do it all at once, would it make sense to throw together something on the website in asciidoc for some common usage examples? Line 1779: slc = new Slice(cpython.PyBytes_AsString(value)) > while we're here, maybe we should add a blanket else: raise Exception("Unab Done http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/util.py File python/kudu/util.py: Line 26: timezone provided. > nit: trailing space Done Line 68: if timestamp.tzinfo and timestamp.utcoffset(): > https://docs.python.org/2/library/datetime.html#datetime.datetime.now says Done -- To view, visit http://gerrit.cloudera.org:8080/4417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
