Will Berkeley has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java: PS2, Line 271: ByteBuffer buf = ByteBuffer.wrap(key); unused variable Line 274: nit: extra blank line http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: Line 223: if (!Iterators.all(partition.getHashBuckets().iterator(), Predicates.equalTo(0))) continue; > nit: I personally prefer if statements to not be on a single line, especial +1 http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS2, Line 804: + 1 no +1 here for equals check PS2, Line 820: // Check that b is 1 byte longer than a, the extra byte is 0, and all other bytes are equal. Stale/copy-paste comment http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java File java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java: PS2, Line 187: Pretty prints nit: Technically this returns a string as opposed to actually printing something; maybe change to something like "Returns a pretty-printed string describing this tablet partition's range component" Line 190: */ nit: add an @return -- To view, visit http://gerrit.cloudera.org:8080/4934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b263d2444314d46533191918833840e75b7ba7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
