Alexey Serbin has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG Commit Message: Nit: if possible, please keep the commit message line length under 72 characters: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines PS2, Line 22: beggining nit: typo, should have been beginning http://gerrit.cloudera.org:8080/#/c/4927/2/src/kudu/util/status.h File src/kudu/util/status.h: PS2, Line 65: and nit: log it as 'msg' at 'level' and return the status PS2, Line 66: KUDU_RETURN_NOT_OK_LOG May be, name it KUDU_LOG_AND_RETURN_MSG() since it's very similar to KUDU_LOG_AND_RETURN()? And re-implement the KUDU_LOG_AND_RETURN() macro via this new macro, dropping the additional 'Status: ' prefix? PS2, Line 69: msg since it's a macro parameter, it's better to enclose it into parenthesis. -- To view, visit http://gerrit.cloudera.org:8080/4927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb906e7240d7a289a7822444bc9cbf748a555efb Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
