David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4927/5//COMMIT_MSG Commit Message: PS5, Line 20: ERROR, someOperation() > nit: please update the order of the arguments here to match the updated sig Done http://gerrit.cloudera.org:8080/#/c/4927/5/src/kudu/util/status.h File src/kudu/util/status.h: PS5, Line 69: << "Status: " > nit: do you think the "Status: " prefix is really necessary here? Yeah, I think is makes is obvious which part of the message is the resulting status of the operation. -- To view, visit http://gerrit.cloudera.org:8080/4927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb906e7240d7a289a7822444bc9cbf748a555efb Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
