David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File src/kudu/util/status.h: PS4, Line 66: level, s, msg > nit: it would read better for me to put the log level before the message, n was just trying to keep this consistent with the one above, but I prefer your suggestion. Done -- To view, visit http://gerrit.cloudera.org:8080/4927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb906e7240d7a289a7822444bc9cbf748a555efb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
