Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test ......................................................................
Patch Set 6: (1 comment) Consider +1 from my side, my browser is playing some tricks with me not showing those radio buttons at the moment. http://gerrit.cloudera.org:8080/#/c/5345/6/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: PS6, Line 1316: shared_ptr > I'm not sure I understand what you mean. What I meant was if you see external_mini_cluster.cc, it uses both client::sp::shared_ptr and std::shared_ptr. So my suggestion was to keep the naked "shared_ptr" for std::shared_ptr and prefix other one with client::sp::(for the std::tr1:: cases). Yeah, with LIBCPP shared_ptr is same in both cases, so feel free to ignore this comment. -- To view, visit http://gerrit.cloudera.org:8080/5345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983e68862b5535f2f95eedd41850a8a88e95e69c Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
