David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/7/src/kudu/integration-tests/delete_table-test.cc File src/kudu/integration-tests/delete_table-test.cc: PS7, Line 1329: // Once the first batch of data has been fetched and there is some more : // to fetch, delete the table. On the error, do not dump stacks: this : // assumes DeleteTable() works; if not, that's not the test which targeted : // to troubleshooting DeleteTable(), there are tests for that in this file. : NO_FATALS(DeleteTable(w.table_name(), ON_ERROR_DO_NOT_DUMP_STACKS)); > I'm not saying errors are about to be ignored. I'm saying that stacks woul cool, just a matter of rephrasing/deleting the comment then -- To view, visit http://gerrit.cloudera.org:8080/5345 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983e68862b5535f2f95eedd41850a8a88e95e69c Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
